Use Apache CSVFormat to quote lookup values for pasting #2614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-chrisj
approved these changes
Aug 11, 2025
| 5 8/1/2025 but wait | ||
| 6 8/2/2025 still more | ||
| """.replace("[F1]", _tsvQuoter.quoteValue(textFieldName)); | ||
| List<List<String>> bulkData = List.of( |
Contributor
There was a problem hiding this comment.
Do we expect to need to convert many paste-bound texts in this way? I expect there are a lot of tests out there using plain formatted TSVs
Member
Author
There was a problem hiding this comment.
There are definitely tons of TSV Strings getting created across our tests. I don't think we need to proactively update things that aren't a problem but we should use these helpers going forward.
That being said, we can't use them universally for editable grid pasting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Introducing an explicit method for quoting lookup values for pasting into an editable grid.
Updating tests to use
EditableGrid.quoteForPasteandTestDataUtils.stringFromRowswill allow us to deprecate and removeTestDataUtils.TsvQuoterwhich is redundant and rarely used for TSVs anymore.Related Pull Requests
Changes
TestDataUtils.TsvQuoterin favor ofEditableGrid.quoteForPasteSampleTypeTestto use test components